More UBSAN fixes #1178
Merged
More UBSAN fixes #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle_standard_into_type_backend::type_ may not be initialized when clean_up() is called, and comparing its value with x_xmltype and other constants was triggering undefined behaviour in this case, so avoid doing it by checking if ociData_ is non-null before doing it. Also modify oracle_standard_use_type_backend in a similar way, even if it doesn't suffer from this problem, for symmetry.
This is similar to 96668e9 (Don't pass null pointers to memcpy() in trivial_blob_backend code, 2024-10-16) and done for the same reason: when there is no data to read/write, the buffer pointer may be null and passing it to memcpy() triggers UBSAN error, so avoid doing it.
Otherwise the errors reported by it could remain unnoticed, as happened with the UB detected in Oracle backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of other problems and make the other ones don't go unnoticed any more.