Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump language version to 9.0 #859

Merged
merged 2 commits into from
Jul 20, 2021
Merged

bump language version to 9.0 #859

merged 2 commits into from
Jul 20, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Jul 20, 2021

Proposed Changes

Since we are now building against net5, we can use C# version 9.0.

https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-9

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm requested a review from jas88 July 20, 2021 14:08
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 49.314% when pulling aa2301a on feature/langversion-9 into 033e4e7 on master.

@jas88 jas88 merged commit 30e98ff into master Jul 20, 2021
@jas88 jas88 deleted the feature/langversion-9 branch July 20, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants