Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify SDK version in global.json #855

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Jul 19, 2021

Proposed Changes

This patch adds a global.json file which specifies the dotnet SDK version to build with. This has the effect of syncing the version of the SDK that is used for local development and all CI checks (including LGTM which is currently specified separately).

The version suggested in this PR (5.0.302) is quite new, so we could roll this back if some developers don't have this installed yet.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm changed the title WIP: test specifying SDK version in global.json Specify SDK version in global.json Jul 19, 2021
@rkm rkm requested a review from tznind July 19, 2021 22:42
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 49.381% when pulling 253b7c5 on feature/dotnet-sdk-specify-version into a258b05 on master.

@rkm rkm merged commit ed9dc48 into master Jul 20, 2021
@rkm rkm deleted the feature/dotnet-sdk-specify-version branch July 20, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants