Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to provide IsIdentifiable arguments in the global y… #795

Merged
merged 6 commits into from
Jun 15, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Jun 14, 2021

…aml configs

Fixes #769

Proposed Changes

Summarise your proposed changes here, including any notes for reviewers.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

@tznind tznind requested a review from rkm June 14, 2021 09:36
@coveralls
Copy link

coveralls commented Jun 14, 2021

Coverage Status

Coverage decreased (-0.2%) to 53.944% when pulling 4ebd6bf on reviewer-fixes into 0a10a4e on master.

rkm
rkm previously approved these changes Jun 14, 2021
@rkm
Copy link
Member

rkm commented Jun 14, 2021

One thing actually if you have time - could we update the default.yaml file with these values?

@tznind tznind mentioned this pull request Jun 14, 2021
11 tasks
@tznind
Copy link
Contributor Author

tznind commented Jun 15, 2021

Can you merge this?, the coveralls check is preventing me merging

@rkm rkm merged commit 63fd851 into master Jun 15, 2021
@rkm rkm deleted the reviewer-fixes branch June 15, 2021 08:44
@tznind tznind mentioned this pull request Jun 29, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying update/ignore lists from yaml file in reviewer
3 participants