Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer async fixes #745

Merged
merged 5 commits into from
May 14, 2021
Merged

Reviewer async fixes #745

merged 5 commits into from
May 14, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented May 14, 2021

Proposed Changes

Summarise your proposed changes here, including any notes for reviewers.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2021

This pull request introduces 2 alerts when merging a149359 into 9fb431d - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

rkm
rkm previously approved these changes May 14, 2021
@tznind tznind merged commit 293bc30 into master May 14, 2021
@tznind tznind deleted the reviewer-async-fixes branch May 14, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants