Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/net5 #713

Merged
merged 9 commits into from
Apr 9, 2021
Merged

Feature/net5 #713

merged 9 commits into from
Apr 9, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Apr 9, 2021

Proposed Changes

Upgrade all projects to net5, and fixup corresponding CI configs.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm requested a review from jas88 April 9, 2021 08:17
@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request introduces 3 alerts and fixes 2 when merging c7d7d95 into c618b22 - view on LGTM.com

new alerts:

  • 3 for Missing Dispose call on local IDisposable

fixed alerts:

  • 2 for Dereferenced variable may be null

@rkm
Copy link
Member Author

rkm commented Apr 9, 2021

Let's tackle those new(?) LGTM issues as a separate PR

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request introduces 3 alerts and fixes 2 when merging a0105b2 into c618b22 - view on LGTM.com

new alerts:

  • 3 for Missing Dispose call on local IDisposable

fixed alerts:

  • 2 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request fixes 2 alerts when merging 58883ed into c618b22 - view on LGTM.com

fixed alerts:

  • 2 for Dereferenced variable may be null

@jas88 jas88 merged commit 0f7230d into master Apr 9, 2021
@jas88 jas88 deleted the feature/net5 branch April 9, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to .NET 5
2 participants