-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/net5 #713
Merged
Merged
Feature/net5 #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 3 alerts and fixes 2 when merging c7d7d95 into c618b22 - view on LGTM.com new alerts:
fixed alerts:
|
Let's tackle those new(?) LGTM issues as a separate PR |
This pull request introduces 3 alerts and fixes 2 when merging a0105b2 into c618b22 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 2 alerts when merging 58883ed into c618b22 - view on LGTM.com fixed alerts:
|
jas88
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Upgrade all projects to
net5
, and fixup corresponding CI configs.Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]
Checklist
By opening this PR, I confirm that I have:
Issues