Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modality specific rejectors #690

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Mar 29, 2021

Proposed Changes

This PR addresses #687

Added ModalitySpecificRejectors

For example:

ModalitySpecificRejectors:
       - Modalities: SR
         Overrides: true
         RejectorType: Microservices.CohortExtractor.Execution.RequestFulfillers.RejectNone

Note that the Overrides property will override ALL rules including 'opt out' style rules. So we may want instead to move the dynamic rejector we currently have (throws out non PRIMARY / non SECONDARY) to be the modality specific on CT,MR,DX etc

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

@tznind tznind requested a review from rkm March 29, 2021 12:42
@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2021

This pull request introduces 1 alert when merging 86cff47 into a1c3385 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@tznind tznind requested a review from howff March 29, 2021 13:21
@tznind tznind merged commit b3c27ae into master Mar 29, 2021
@tznind tznind deleted the modality-specific-rejectors branch March 29, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants