Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage collect (and report progress) every 1000 records #646

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

howff
Copy link
Contributor

@howff howff commented Mar 4, 2021

Proposed Changes

Summarise your proposed changes here, including any notes for reviewers.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

@howff howff requested a review from tznind March 4, 2021 11:51
@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2021

This pull request introduces 2 alerts when merging ff8d84f into fe5f336 - view on LGTM.com

new alerts:

  • 1 for Call to GC.Collect()
  • 1 for Possible loss of precision

tznind
tznind previously approved these changes Mar 4, 2021
@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2021

This pull request introduces 2 alerts when merging 17a7f78 into fe5f336 - view on LGTM.com

new alerts:

  • 1 for Call to GC.Collect()
  • 1 for Possible loss of precision

@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2021

This pull request introduces 2 alerts when merging bec374e into fe5f336 - view on LGTM.com

new alerts:

  • 1 for Call to GC.Collect()
  • 1 for Possible loss of precision

@howff howff requested a review from jas88 March 4, 2021 16:23
@jas88 jas88 merged commit 89d0f2d into master Mar 4, 2021
@jas88 jas88 deleted the bugfix/IsIdentifiable-GC branch March 4, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants