Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise IsIdentifiableReviewer namespace #632

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Feb 26, 2021

Proposed Changes

Normalise the IsIdentifiableReviewer namespace to match the other Applications.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm marked this pull request as ready for review February 26, 2021 15:25
tznind
tznind previously approved these changes Feb 26, 2021
@rkm rkm force-pushed the normalise-namesapce branch from dad0f62 to 79efaa2 Compare February 26, 2021 18:27
@rkm
Copy link
Member Author

rkm commented Feb 26, 2021

@tznind apols, I had to fix-up a test so your review was dismissed. Could you re-approve? :)

@rkm rkm merged commit 5ccb604 into master Mar 1, 2021
@rkm rkm deleted the normalise-namesapce branch March 1, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants