Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reviewer improv 2 #618

Merged
merged 8 commits into from
Feb 22, 2021
Merged

Feature/reviewer improv 2 #618

merged 8 commits into from
Feb 22, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Feb 22, 2021

Proposed Changes

Summarise your changes, and include a link to the CHANGELOG diff.

image

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

@tznind tznind requested a review from howff February 22, 2021 11:59
@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2021

This pull request introduces 4 alerts when merging 4ae2d95 into cc7da4d - view on LGTM.com

new alerts:

  • 2 for Possible loss of precision
  • 2 for Missing Dispose call on local IDisposable

howff
howff previously approved these changes Feb 22, 2021
@tznind
Copy link
Contributor Author

tznind commented Feb 22, 2021

@howff please can you approve again, had merge conflicts in changelog and it has dismissed your review

@tznind tznind merged commit 8d53f61 into master Feb 22, 2021
@tznind tznind deleted the feature/reviewer-improv-2 branch February 22, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants