Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/value updater #440

Merged
merged 12 commits into from
Nov 3, 2020
Merged

Feature/value updater #440

merged 12 commits into from
Nov 3, 2020

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Nov 2, 2020

Proposed Changes

Added new service UpdateValues which propagates changes (e.g. ECHI mapping changes) throughout the deployed database tables.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

@tznind tznind requested a review from rkm November 2, 2020 13:10
@tznind tznind changed the base branch from master to develop November 2, 2020 13:10
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request introduces 1 alert when merging e4fa254 into 8515f05 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

rkm
rkm previously approved these changes Nov 2, 2020
Copy link
Member

@rkm rkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

We'll need to update the RabbitMQ configs and architecture diagrams once we have the other bits of this pipeline in place, but this PR is good for now.

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 1 alert when merging 897d317 into 8515f05 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@tznind tznind marked this pull request as ready for review November 3, 2020 14:32
@tznind tznind requested a review from rkm November 3, 2020 14:32
@tznind tznind merged commit 65fcfe4 into develop Nov 3, 2020
@tznind tznind deleted the feature/value-updater branch November 3, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants