Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for pooled extractions (not used yet) #2042

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Dec 8, 2024

Proposed Changes

Initial options for extraction file pool.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (39d4b9d) to head (dd821bf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...es/Applications/ExtractImages/ExtractImagesHost.cs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
+ Coverage   65.56%   65.67%   +0.11%     
==========================================
  Files         183      183              
  Lines        6554     6576      +22     
  Branches      967      973       +6     
==========================================
+ Hits         4297     4319      +22     
  Misses       1966     1966              
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review December 8, 2024 18:38
@rkm rkm requested a review from jas88 December 8, 2024 18:39
@rkm rkm merged commit e559c73 into main Dec 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants