Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump SDK to 9.0.100 #2018

Merged
merged 3 commits into from
Nov 21, 2024
Merged

bump SDK to 9.0.100 #2018

merged 3 commits into from
Nov 21, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Nov 21, 2024

Proposed Changes

.NET 9!

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@rkm
Copy link
Member Author

rkm commented Nov 21, 2024

I don't think codeql has support for this yet, so we may be blocked for a while

@rkm
Copy link
Member Author

rkm commented Nov 21, 2024

I don't think codeql has support for this yet, so we may be blocked for a while

Just needed the SDK installed!

@rkm rkm marked this pull request as ready for review November 21, 2024 18:47
@rkm rkm enabled auto-merge (rebase) November 21, 2024 18:47
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.46%. Comparing base (4eca2fc) to head (616baca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files         183      183           
  Lines        6556     6556           
  Branches      966      966           
=======================================
  Hits         4292     4292           
  Misses       1973     1973           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rkm rkm merged commit 2bc61e0 into main Nov 21, 2024
19 checks passed
@rkm rkm deleted the feature/net9 branch November 21, 2024 18:57
@rkm rkm mentioned this pull request Nov 24, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant