Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime selection in scripts #2015

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fix runtime selection in scripts #2015

merged 3 commits into from
Nov 21, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Nov 21, 2024

Proposed Changes

Reverts #2013.

Use the msbuild property UseCurrentRuntimeIdentifier=True" where --use-current-runtime` is not available.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@rkm rkm force-pushed the fix/runtime-selection branch from 4acf9b8 to 10bd8bf Compare November 21, 2024 17:05
@rkm rkm marked this pull request as ready for review November 21, 2024 17:05
@rkm rkm enabled auto-merge (rebase) November 21, 2024 17:05
@rkm rkm merged commit 023e592 into main Nov 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant