add packages lockfile

Directory.Build.props

@@ -10,6 +10,8 @@
     <LangVersion>12.0</LangVersion>
     <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
     <Nullable>enable</Nullable>
+    <RestoreLockedMode Condition="'$(CI)' == 'true'">true</RestoreLockedMode>
+    <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
     <RunSettingsFilePath>$(MSBuildThisFileDirectory)\nunit.runsettings</RunSettingsFilePath>
     <RuntimeIdentifiers>linux-x64;win-x64;osx-arm64</RuntimeIdentifiers>
     <SatelliteResourceLanguages>none</SatelliteResourceLanguages>

bin/common.py

@@ -141,3 +141,9 @@ def start_containers(
             )
             run(cmd)
             raise
+
+def is_ci() -> bool:
+    ci = os.environ.get("CI", None)
+    if ci is None:
+        return False
+    return ci == "1" or ci.lower() == "true"

bin/smi/build.py

@@ -33,12 +33,27 @@ def main(argv: Optional[Sequence[str]] = None) -> int:
         )
         C.run(cmd)
 
+    # NOTE This isn't necessarily needed, but the lockfile processing isn't
+    # otherwise transparent in the build output
+    if C.is_ci():
+        cmd = (
+            "dotnet",
+            "restore",
+            "-warnaserror",
+            "--use-current-runtime",
+            "--nologo",
+            "--locked-mode",
+            "--force",
+        )
+        C.run(cmd)
+
     cmd = (
         "dotnet",
         "build",
         "-warnaserror",
         "--use-current-runtime",
         "--configuration", args.configuration,
+        "--no-restore" if C.is_ci() else "",
         "--verbosity", "quiet",
         "--nologo",
     )

bin/smi/buildTestPackage.py

@@ -50,7 +50,11 @@ def main() -> int:
             return rc
 
     # Package
-    rc = DP.main((*cfg_args, args.tag))
+    rc = DP.main((
+        *cfg_args,
+        "--no-build",
+        args.tag,
+    ))
 
     return rc
 

bin/smi/writeDatabaseStrings.py

@@ -14,13 +14,6 @@
 assert _TEST_DBS_TXT.is_file()
 
 
-def _is_ci() -> bool:
-    ci = os.environ.get("CI", None)
-    if ci is None:
-        return False
-    return ci == "1" or ci.lower() == "true"
-
-
 def main() -> int:
 
     parser = argparse.ArgumentParser()
@@ -41,7 +34,7 @@ def main() -> int:
             f.write(f"SqlServer: 'Server={args.mssql_server};User Id=sa;Password={args.db_password};TrustServerCertificate=true;'\n")
 
         # NOTE(rkm 2022-02-27) We don't run MySQL in Windows in GitHub actions
-        if not (os.name == "nt" and _is_ci()):
+        if not (os.name == "nt" and C.is_ci()):
             f.write(f"MySql: 'server=127.0.0.1;Uid=root;Pwd={args.db_password};sslmode=None'\n")
 
     with open(_RELATIONAL_YAML) as f:
@@ -53,7 +46,7 @@ def main() -> int:
         f.write("Prefix: TEST_\n")
         f.write("Username: sa\n")
         f.write(f"Password: {args.db_password}\n")
-        if not (os.name == "nt" and _is_ci()):
+        if not (os.name == "nt" and C.is_ci()):
             f.write(f"MySql: server=127.0.0.1;Uid=root;Pwd={args.db_password};sslmode=None\n")
 
     with open(_TEST_DBS_TXT) as f:

news/1875-meta.md

@@ -0,0 +1 @@
+Enable Nuget packages restore with lockfile