Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to NET7 and C# 11 #1637

Merged
merged 5 commits into from
Oct 3, 2023
Merged

upgrade to NET7 and C# 11 #1637

merged 5 commits into from
Oct 3, 2023

Conversation

rkm
Copy link
Member

@rkm rkm commented Sep 25, 2023

Proposed Changes

Upgrades the SDK and language versions.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e85918) 68.50% compared to head (45a79f3) 68.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1637   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files         185      185           
  Lines        6550     6550           
=======================================
  Hits         4487     4487           
  Misses       2063     2063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review October 3, 2023 12:40
@rkm rkm requested review from jas88 and darshad-github October 3, 2023 13:07
@jas88 jas88 merged commit 4e0e0e7 into master Oct 3, 2023
@jas88 jas88 deleted the feature/net7.0 branch October 3, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants