Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay creation of extraction directory until user confirms the settings #913

Closed
rkm opened this issue Sep 24, 2021 · 0 comments · Fixed by #914
Closed

Delay creation of extraction directory until user confirms the settings #913

rkm opened this issue Sep 24, 2021 · 0 comments · Fixed by #914
Assignees
@rkm
Labels
type/bug Something isn't working

Comments

@rkm
Copy link
Member

rkm commented Sep 24, 2021

SmiServices/src/applications/Applications.ExtractImages/ExtractImagesHost.cs

Line 64 in 4776373

_fileSystem.Directory.CreateDirectory(absoluteExtractionDir);

Currently if you attempt to start an extraction, cancel at the prompt, and try to re-run, this crashes since the extraction directory is eagerly created.
@rkm rkm added the type/bug Something isn't working label Sep 24, 2021
@rkm rkm self-assigned this Sep 24, 2021
rkm added a commit that referenced this issue Sep 24, 2021
@rkm
Delay extraction directory creation to just before messages are sent
7cd01d0 
Fixes #913
@rkm rkm mentioned this issue Sep 24, 2021
Merged
11 tasks
rkm added a commit that referenced this issue Sep 28, 2021
@rkm
Delay extraction directory creation to just before messages are sent
fe32214 
Fixes #913
rkm added a commit that referenced this issue Sep 28, 2021
@rkm
Delay extraction directory creation to just before messages are sent
e45ff68 
Fixes #913
@rkm rkm closed this as completed in #914 Sep 29, 2021
rkm added a commit that referenced this issue Oct 2, 2021
@rkm
Delay extraction directory creation to just before messages are sent
c0d012a 
Fixes #913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkm rkm

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delay extraction directory creation to just before messages are sent SMI/SmiServices
1 participant
@rkm