Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractorCLI should not block specifying Modality when doing Series level extractions #695

Closed
tznind opened this issue Apr 1, 2021 · 0 comments · Fixed by #697
Closed
Assignees
Labels
type/bug Something isn't working

Comments

@tznind
Copy link
Contributor

tznind commented Apr 1, 2021

Also the ExtractorCLI tool blocks extractions with modality specified unless you pass it StudyInstanceUIDs... need to remember if there's a specific reason for that check being there

@rkm

I believe the logic was: Studies have multiple modalities but Series are only a single Modality. So when you get a PT,CT combo scan then there should be a Series for the PT and a different one for the CT. So the idea was that you would only really need to specify a Modality when you are specifying a Study level extraction

I suspect that logic is flawed though, I seem to remember hearing about SR images being tacked onto the end of existing Series with the same SeriesInstanceUID as the rest of the extraction. Either way we shouldnt be blocking specifying Modality as it reduces the number of tables we have to query.

@rkm rkm added the type/bug Something isn't working label Apr 1, 2021
@rkm rkm self-assigned this Apr 1, 2021
@rkm rkm closed this as completed in #697 Apr 1, 2021
rkm added a commit that referenced this issue Apr 1, 2021
* Remove block on SeriesInstanceUID+Modality in CohortPackager

* Remove block on SeriesInstanceUID+Modality in ExtractorCLI

* Remove case from test

* remove Java test case

* Enable modality case in log statement

* add news file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants