Type hint commands modules #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkc
approved these changes
Jan 31, 2025
gens/db/annotation.py
Outdated
| @@ -17,7 +18,7 @@ | |||
| UPDATES = "updates" | |||
|
|
|||
|
|
|||
| def register_data_update(track_type, name=None): | |||
| def register_data_update(track_type: str, name: Optional[str]=None): | |||
There was a problem hiding this comment.
Optional[str] kan också skrivas som str | None. Kanske är tydligare?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type hinting started for command and db modules.
Will need testing after updating to 3.12, as it currently uses syntax not supported by 3.8.
The parts touching on Mongo are tricky to get typed correctly. Hopefully #191 will help, at least in part.
Not sure it will resolve the
MongoClientinstance typings, which seems to expect a subtype for the generics. Maybe a bit more googling will help.Review: