Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to OrdinaryDiffEqCore #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChrisRackauckas
Copy link

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (e9de366) to head (3f0fe78).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   98.24%   98.03%   -0.21%     
==========================================
  Files           7        7              
  Lines        1538     1528      -10     
==========================================
- Hits         1511     1498      -13     
- Misses         27       30       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha
Copy link
Collaborator

ranocha commented Aug 27, 2024

@SKopecz If we switch to the reduced dependency OrdinaryDiffEqCore.jl, we will have to drop supporting Julia 1.9 here...

@SKopecz
Copy link
Owner

SKopecz commented Aug 27, 2024

@SKopecz If we switch to the reduced dependency OrdinaryDiffEqCore.jl, we will have to drop supporting Julia 1.9 here...

I'm not sure how important Julia 1.9 support is. I'd leave this up to you.

@ranocha
Copy link
Collaborator

ranocha commented Aug 28, 2024

I would be fine dropping support for Julia 1.9. Let's first finish #108, make a new release of PositiveIntegrators.jl, and then drop support for Julia 1.9 together with this PR.

@ranocha
Copy link
Collaborator

ranocha commented Aug 30, 2024

Let's do the breaking change of #112 together with dropping support for Julia 1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants