cleanup ftp publisher code #64
Conversation
allow well formated uris throw error on wrong scheme
| except Exception as error: | ||
| BasePublisher.print_exception(self, error) | ||
| finally: | ||
| os.remove(filename) |
There was a problem hiding this comment.
Initially I thought finally is not a good place for os.remove(), because it wipes the file even if the upload was not successful. That's why in the original version it was inline, and also the reason why someone thought temporary local file names should be predictable (to allow troubleshooting).
However on the other read of our code, we should probably handle this better upstream, and also prevent a race condition with naming at the same time. I'll open an issue for that, and accept this code so the failed uploads don't clutter the container forever.
There was a problem hiding this comment.
Or use else: in the try-except clause
There was a problem hiding this comment.
we could have just left it as it was, but I like this approach, followed by more cleanup which I propose in #66
allow well formated uris
throw error on wrong scheme