Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About and other stuff #137

Merged
merged 9 commits into from
Apr 8, 2020
Merged

About and other stuff #137

merged 9 commits into from
Apr 8, 2020

Conversation

idelmr
Copy link
Contributor

@idelmr idelmr commented Apr 8, 2020

Description

  • Modify about page to better reflect "common" app about screens, reflect the version number, github, version number, etc.
  • Delete unnecessary files that were previously being used by About, mainly Version.js and WebPageShow.js
  • Delete old files no longer being used
  • Remove inline styling in NavBar component and add childStyle prop
  • Add leaderboard search icon as a child to the NavBar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (specify below)

Checklist:

  • My code follows the code style of this project found on Contribution guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@idelmr idelmr requested review from HanielDiaz and esteban737 April 8, 2020 02:28
HanielDiaz
HanielDiaz requested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@HanielDiaz HanielDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few changes for you to look at. If you don't agree with any of these just let me know why you don't so we can talk about it and make sure we have the best code

@idelmr idelmr requested a review from HanielDiaz April 8, 2020 06:38
HanielDiaz
HanielDiaz approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@HanielDiaz HanielDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@HanielDiaz HanielDiaz merged commit 952fc17 into master Apr 8, 2020
@HanielDiaz HanielDiaz deleted the about_and_other_stuff branch April 8, 2020 17:41
@idelmr idelmr mentioned this pull request Mar 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanielDiaz HanielDiaz HanielDiaz approved these changes

@esteban737 esteban737 Awaiting requested review from esteban737

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idelmr @HanielDiaz