Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Component #74

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Calendar Component #74

wants to merge 8 commits into from

Conversation

gabriel-flynn
Copy link
Member

  • Still need to get the SHPE calendar information to set it up correctly, I tested it locally with my calendar and it works great
  • Need to make sure it's ok for the calendar API key to be public - it seems like it should since FullCalendar has it stored publicly
  • Do we want to include the final design of the calendar page in this issue? If not seems like getting the calendar to be sized correctly and do any finishing touches to the calendar page could be a good beginnerish issue

Closes #72

@gabriel-flynn gabriel-flynn requested a review from rigrergl June 14, 2021 03:35
Copy link
Contributor

@rigrergl rigrergl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks so much better than the default one from google!

  • I agree customizing it is a good beginner issue.
  • About the api key, we can always just store it as an environment variable in either Vercel or Netlify (wherever we end up deploying) if you're worried having it public might be dangerous
  • I'll talk with the rest of the officers at the meeting this Wednesday to double check which calendar is going to be used in order to set it up with the proper SHPE calendar info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing Calendar Bug
2 participants