daide string generation and tests #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #26
mjspeck
requested changes
Nov 9, 2022
There was a problem hiding this comment.
I got a couple of formatting changes when I ran black so you might need to run it on your end. If you did the changes could be due to a difference in configurations which we should address in another ticket. Aside from that, there are a couple of minor changes to make which I've listed in the comments. Once those are addressed this should be good to go.
P.S. since this is a pretty big change, bump the version in setup.cfg to 0.2.0. We can set up automatic versioning in the future.
byung-o
deleted the
26-support-daide-string-construction-from-keyword-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #26