-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to optionally provide a custom key for nsupdate #17
Conversation
This feature allows for having a pre-generated keyfile, which can be used to overcome permission issues regarding the auto-generated keyfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
The documentation is alright!
In general, I think we should rather pass the keyfile as argument in the sftdyn config file, where we can customize the nsupdate command anyway. Then one does not need to modify the systemd unit and invocation, but instead just write it in the sftdyn config. What are your thoughts on that?
Instead of explaining how to set the keyfile as a command line parameter, use the configuration file instead for a simpler setup.
It turns out the nskeyfile option was already usable from the conf file, but I had forgotten about it. I changed the documentation to use the config instead of overriding the systemd unit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
Unless you have any additions, we can merge it. Maybe, as a future extension, we can allow to specify arbitrary additional command line options in the config file. |
I have nothing else planned. Yes, I suppose the whole feature could be replaced by a setting that lets you specify nsupdate parameters. |
This PR implements the feature requested in the issue #13.
New option
--nskeyfile
can be used to provide a pre-generated keyfile, which will be then passed to nsupdate using the-k
argument.Open for suggestions, changes or a complete takeover of the PR.
This to consider:
--nskeyfile
with no shorthand, since-k
is already taken.