Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of obsolete ImGui functions #302

Closed
wants to merge 4 commits into from

Conversation

Legulysse
Copy link
Contributor

This PR contains migration commits to allow imgui-sfml to be compiled with the flag IMGUI_DISABLE_OBSOLETE_FUNCTIONS.
I put them in the order of imgui updates for easier integration if needed.

Those commits will force the project to raise the minimum imgui version supported, so it may not be welcome right now.
However, it can be useful for people willing to enforce this compilation flag on their projects.
I am not familiar with cmake and thus I am unable to tweak/test the version settings on this part.

Please feel free to use those commits as you see fit, either by cherry-picking them at a later time, or by merging them into a different branch.

This PR is tied to this ticket : #301

@ChrisThrasher ChrisThrasher changed the title 2.6.x imgui update fix Remove use of obsolete ImGui functions Oct 27, 2024
@ChrisThrasher
Copy link
Member

Now that CI is checking for the use of obsolete functions, if we want to remove more obsolete functions then what we're really doing is raising the minimum ImGui requirement. That's a valid thing to consider, I just want to make sure we're on the same page about what it entails.

For now I'm going to close this PR because as it stands I'm not yet sure I want to raise the ImGui requirement for ImGui-SFML 2. ImGui-SFML 3 on the other hand certainly ought to raise that requirement. I'm not sure what version to pick but I think something newer is in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants