Fixed unable to build SFML with latest Android NDK #1575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for making a contribution to SFML! 🙂
Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)
Description
SFML could not be built using the latest NDK, since CMake did not find any libraries (such as OpenAL).
This PR will fix this.
The problem was caused by the the changes added in NDK r19b. Since then, NDK adds its root path to
CMAKE_FIND_ROOT_PATH
. To tell CMake to also search for the libraries in SFML's directory, we have to add it toCMAKE_FIND_ROOT_PATH
too.Tasks
How to test this PR?
Try to build SFML using the latest (r19c) Android NDK. Without this PR, it will fail.