Datetime features #729
Merged
Datetime features #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescod
force-pushed
the
feature/create-date-time-from-date
branch
from
5eda3c5 to
c481d50
Compare
TheBitShepherd
approved these changes
Sep 26, 2022
| start_date: 1999-12-31 11:59:00 | ||
| end_date: now | ||
| timezone: | ||
| relativedelta: |
There was a problem hiding this comment.
Are there other options besides relativedelta? Is there a syntax to specify a timezone with a traditional abbreviation? (e.g. timezone: PST)
| basedate: ${{datetime("2022-01-01", year=2000, month=1, day=1)}} | ||
| dateplus: ${{basedate + "XYZZY"}} | ||
| """ | ||
| with pytest.raises(exc.DataGenValueError) as e: |
There was a problem hiding this comment.
You could save a line by using the match argument. My regex-fu could be off here though :)
Suggested change
| with pytest.raises(exc.DataGenValueError) as e: | |
| with pytest.raises(exc.DataGenValueError, match=r'/date specification/') as e: |
| with pytest.raises(exc.DataGenError) as e: | ||
| generate(StringIO(yaml), {}, None) | ||
|
|
||
| assert "date specification" in str(e.value) |
There was a problem hiding this comment.
Same comment as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
datetime_betweenfeatureAllow datetimes to be parsed from strings
Allow datetimes to be coerced from dates