Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decimal datatype #631

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Allow decimal datatype #631

merged 1 commit into from
Apr 1, 2022

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Mar 22, 2022

Decimal fakers were causing a problem because there was no serialization rule for them.

In the process of fixing it I discovered another small bug relating to this syntax:

fieldname: ${{fake.foo}}

This was causing an exception in the new Native Types mode of Snowfakery. Now it's fixed.

@prescod prescod requested a review from a team as a code owner March 22, 2022 17:00
@prescod prescod requested a review from boakley March 22, 2022 20:55
boakley
boakley approved these changes Apr 1, 2022
View reviewed changes
Copy link

@boakley boakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any red flags. This looks pretty straight-forward and I appreciate
the comments in the code related to the jinja quirk.

@prescod
Copy link
Contributor Author

prescod commented Apr 1, 2022

Closes #630

@prescod prescod merged commit cc62e19 into main Apr 1, 2022
@prescod prescod deleted the feature/decimal-datatype branch April 1, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boakley boakley boakley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prescod @boakley