Datetimes have a UTC timezone by default #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescod
commented
Feb 3, 2022
| return mockobj._index[tablename][index][field] | ||
| else: # return a full row | ||
| return mockobj._index[tablename][index] | ||
| if index is None: # return all rows |
There was a problem hiding this comment.
These are some improvements to the testing infrastructure to make certain kinds of assertions easier to write. It doesn't require a deep review because it isn't user-facing code and it gets well-tested by virtue of being a test suite.
jstvz
previously approved these changes
Feb 3, 2022
| @@ -585,7 +585,11 @@ def executable_blocks(self): | |||
| return {**self.field_funcs(), "fake": self.fake} | |||
|
|
|||
| def fake(self, name): | |||
| return str(self.runtime_context.faker_template_library._get_fake_data(name)) | |||
| val = self.runtime_context.faker_template_library._get_fake_data(name) | |||
| if isinstance(val, Scalar.__args__): | |||
There was a problem hiding this comment.
Can use typing.get_args() here instead:
Suggested change
| if isinstance(val, Scalar.__args__): | |
| if isinstance(val, T.get_args(scalar)): |
There was a problem hiding this comment.
I didn't do it exactly that way but: b622e7c
There was a problem hiding this comment.
@prescod Did you mean to replace this with ScalarTypes?
| return mockobj._index[tablename][index][field] | ||
| else: # return a full row | ||
| return mockobj._index[tablename][index] | ||
| if index is None: # return all rows |
tests/test_faker.py
Outdated
Comment on lines
131
to
132
| assert "+0" in dt or dt.endswith("Z"), dt | ||
| assert dateparser.parse(dt).tzinfo |
There was a problem hiding this comment.
What about using dateparser.isoparse() instead? parse is pretty liberal about what it accepts.
Co-authored-by: James Estevez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides Faker's DateTime-generating methods to return DateTimes with timezone set to UTC by default. Other timezones can be specified as a
relativedelta. Timezone handling can be turned off by specifyingFalse.