Remove uses of sets() which make iteration order unpredictable. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What work item is this related to? |
|
It's related to an issue reported by users in Slack. |
added 2 commits
December 23, 2021 21:50
prescod
force-pushed
the
feature/ordered-sets
branch
from
0cf4672 to
a119a56
Compare
davisagli
reviewed
Dec 28, 2021
docs/salesforce.md
Outdated
| @@ -51,6 +50,14 @@ $ cci flow run test_everything | |||
| ... | |||
| ``` | |||
|
|
|||
| The order in which sobjects is loaded is inferred by Snowfakery and CumulusCI | |||
There was a problem hiding this comment.
Suggested change
| The order in which sobjects is loaded is inferred by Snowfakery and CumulusCI | |
| Snowfakery and CumulusCI infer the order in which sObjects are loaded |
docs/salesforce.md
Outdated
| @@ -51,6 +50,14 @@ $ cci flow run test_everything | |||
| ... | |||
| ``` | |||
|
|
|||
| The order in which sobjects is loaded is inferred by Snowfakery and CumulusCI | |||
There was a problem hiding this comment.
Suggested change
| The order in which sobjects is loaded is inferred by Snowfakery and CumulusCI | |
| Snowfakery and CumulusCI infer the order in which sObjects are loaded |
|
Text is now: Snowfakery and CumulusCI infer the order in which sObjects are loaded |
davisagli
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that in some cases her recipe loaded okay and in other cases it failed. The underlying cause of the failed loads is that there are two tables that had an implicit, not explicit, dependency. A picklist populated by CampaignMemberStatus had to be loaded before CampaignMembers could be.
We already have a way to force a load order, but my concern was that the intermittent behaviour made tracking down the source of the problem harder.
Also: the user's mental model was that the load order would follow the recipe.
AC:
This change ensures that the load order does actually follow the recipe except if a dependency can be inferred. Dependency order takes priority over recipe declaration order.