Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close datasets properly #492

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Close datasets properly #492

merged 2 commits into from
Sep 23, 2021

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Sep 23, 2021

Some extra code to ensure that datasets are closed in an orderly fashion. Should fix a Tempfile-related exception on Windows.

@prescod prescod requested a review from a team as a code owner September 23, 2021 18:01
@prescod prescod requested a review from jofsky September 23, 2021 18:26
@prescod prescod merged commit 224d7ac into main Sep 23, 2021
@prescod prescod deleted the feature/close-datasets-properly branch September 23, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants