Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macros can include other macros #120

Merged
merged 7 commits into from
Sep 15, 2020
Merged

Macros can include other macros #120

merged 7 commits into from
Sep 15, 2020

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Aug 27, 2020

For example:

- macro: foo
  fields:
    foobar: FOOBAR

- macro: bar
  include: foo
  fields:
    barbar: BARBAR

- object: Bar
  include: bar

Generates:

Bar(id=1, barbar=BARBAR, foobar=FOOBAR)

davisagli
davisagli suggested changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs?

@prescod
Copy link
Contributor Author

prescod commented Sep 15, 2020

This PR changes the implementation to match the docs.

https://snowfakery.readthedocs.io/en/docs/#macros

"Macros can themselves include other macros."

@prescod prescod requested a review from davisagli September 15, 2020 14:44
@prescod prescod merged commit 7edd58f into master Sep 15, 2020
@prescod prescod deleted the feature/macros-include-macros branch September 15, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees

@prescod prescod

@davisagli davisagli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prescod @davisagli