Set up ScopedRateThrottle for endpoint-specific rate limits #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update node version to latest LTS - Copy/paste pyjs dockerfile - temporarily ignore optional deps - Pytest no longer on PATH - Ignore tsc error - Remove coverage step - suppress eslint errors
PR #3544 disabled ratelimiting for AdminAPI views. This change improves control over rate limits and helps prevent over-throttling. - Removed global throttles (`AnonRateThrottle`, `UserRateThrottle`) - Added `ScopedRateThrottle` to control rate limits per endpoint - Defined custom rate to protect AdminAPI endpoints from DoS @W-17141510
jstvz
force-pushed
the
admin-api-rate-limits
branch
from
461ed65 to
60a5571
Compare
vsbharath
previously approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3544 disabled ratelimiting for AdminAPI views. This change improves control over rate limits and helps prevent over-throttling.
AnonRateThrottle,UserRateThrottle)ScopedRateThrottleto control rate limits per endpoint@W-17141510