PDS3 maintenance update; new attributes in Pds3File #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pds3file/__init__.py
andpds4file/__init__.py
will contain only the source code that is unique to each subclass. Ideally, the constructor for PdsFile should immediately raise an exception. If you are not thinking of PdsFile in this way, we should discuss it.pds3file/__init__.py
, I added some of the "aliases" we discussed recently in the Slack channel, using "vol" in place of "bundle". This includes the aforementioned regular expressions. These are additions to the file so they shouldn't break anything.pdsdependency.py
had some broken regular expressions for specifying the New Horizons browse products, so these were not being checked properly. That is now fixed.re-validate.py
stopped working for me, apparently having something to do with refererences to PdsFile that should have been references to Pds3File. I did not pursue this question very far; I just made sufficient changes forre-validate
to work again.crlf.py
that can check or repair line terminators. It is now in themaintenance/pds3
subdirectory.