fix: Create toast fix #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… success messages up to the views
EwoutV
approved these changes
May 23, 2024
EwoutV
added a commit
that referenced
this pull request
May 23, 2024
* chore: changed production docker (#432) * chore: changed production docker * chore: modified tests as well * chore: celery * fix: Admin panel fix (#427) * chore: make /admin/ redirect to /admin/users/ #356 * chore: make change size depending on screen size #356 * chore: replace "public" ToggleButton by a ToggleSwitch #356 * chore: add "remove" button #356 * chore: visual layout remove button for selected docker images #356 * chore: make multiRemove button disabled when nothing's selected #356 * chore: add selectedItems variable, so I can reach that when the objects are actually being removed #356 * chore: error message for case saving when no item is selected (shouldn't actually happen ever) #356 * chore: not able to upload when there is no name for docker image #356 * chore: make selection an option instead of mandatory for LazyDataTable #356 * chore: documentation UsersView #356 * chore: documentation DockerImagesView #356 * chore: translations + try at allowing and file upload after 1st upload #356 * chore: change to list when uploading #356 * chore: after dockerImage is removed separately, remove it from list of selectedItems #356 * chore: implement multiRemove of docker images #356 * fix: lint fix #356 * fix: correct "or" filter for functions of user to an "and" filter #356 * docs: extra documentation of DockerImagesView.vue #356 * fix: replace Dialog by ConfirmDialog #356 * style: linting fix #356 * docs: extra doc for DockerImagesView.vue #356 * chore: translation corrections #356 * chore: joining of functions (fillCreators and fillDestroyers) for a code execution speedup (hopefully) #356 * style: lint fix #356 * chore: change word in header in admin panel from "ypovoli" to "admin" #356 * chore: translation fixes #356 * chore: forgot to remove stuff in Dutch translations #356 * chore: no extra checks fix * Adds all possible error messages to submission fixtures * Cleanup translations (#442) * fix: show toggle button project list also when there are only projects in the past * fix: cleanup translations * fix: default submission status argument * chore: remove unused translations * chore: cleanup translations * fix: linting * fix: no leaving single groups (#441) * chore: send notifications * chore: simplify extra checks count * fix: linting errors * --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * feat: treeview (wip) * feat: structure check tree view * chore: added files * chore: backend for structure checks * feat: working tree builder * feat: working tree builder * chore: tests * chore: fixes and improvements * chore: frontend tests (wip) * chore: moved notification sender * chore: linting * chore: frontend tests (wip) * chore: cleanup * fix: docker image validation * chore: PR comments * fix: backend tests * Toast messages upon creation of objects (#437) * chore: course creation toast message #407 * chore: project creation toast message #407 * chore: add Dutch translations #407 * chore: submission creation success toast message #407 * chore: submission creation success toast message dutch #407 * chore: remove punctuation at end of sentence #407 * chore: restructure imports #407 * chore: helper function that also shows a toast message upon successful creation #407 * chore: make general for now #407 * chore: abstract and give type to fill in correct type in toast message #407 * chore: log errors when creating with custom message #407 * chore: actually remove try catch block, because it's not necessary #407 * chore: add punctuation at end of full sentences #407 * chore: replace a fromJSON #407 * chore: try to fix test #407 * style: lint fix #407 * test: fix test #407 * style: lint fix #407 * fix: create serializer * fix: toggle show artifact * feat: project views, footer (#452) * feat: project views * fix: project permissions * fix: backend tests * chore: project views * fix: permissions * fix: linting * chore: fixes * chore: added socials * chore: better error messages (#446) * chore: make services throw errors to caller if requested * chore: make services throw errors to caller if requested * chore: place init?:boolean back * chore: rewrite landers code * chore: fix linter * chore: fix linter * chore: fix linter * chore: fix linter * chore: fix linter * chore: fix linter * chore: fix linter * chore: fix linter * chore: first part of merge * fix: project service * chore: linting * chore: fix help * chore: merge & toast example --------- Co-authored-by: EwoutV <[email protected]> * test: Course test (#450) * chore: add loads of changes to login mechanism for testing (possible options are admin, student, and all roles at the same time) #434 * chore: login users beforehand (might delete this in the future actually) #434 * chore: trying to fix adding data before tests #434 * chore: more trial and error #434 * chore: struggling.. #434 * chore: so close, but yet so far #407 * chore: fix location of preprocessor #407 * chore: remove unnecessary node events #434 * chore: test.sh script now deletes database and fills with realistic fixtures #434 * test: automatically login all users, before every test file, so that they're available, but also automatically logout after every test #434 * test: set path to supportFile correctly cypress #434 * test: removing logging out for cleaning up #434 * test: add professor login endpoint #434 * test: cleanup #434 * test: course make and course enroll test with id's applied where necessary #434 * test: forgot to actually commit the test file itself #434 * style: lint fix #434 * chore: move filling db to outside --------- Co-authored-by: Topvennie <[email protected]> * chore: remove option private docker images * fix: automatically joining individual projects * fix: translations * fix: linting * chore: confirm dialog before deletion * fix: vue validate error + form selection * Single submission view (#453) * chore: better submission status + favicon (#454) * chore: extra status fields * chore: submission status better than ever * chore: linting * chore: fix tests * chore: favicon * chore: better favicon * fix: typos in realistic fixture * chore: switch project name and ourse name positions * fix: cleanup * chore: clearer submission status * fix: Create toast fix (#456) * chore: remove createToast in helpers.ts and leave showing of creation success messages up to the views * chore: update jdocs of helpers.ts functions to include the selfProcessError parameter * chore: edit of user on admin panel shows success message when successful * chore: edit of docker image on admin panel shows success message when successful * style: lint fix * fix: messed up SubmissionView.vue during rebase, have just completely copied it from development now * fix: display success message when uploading from SubmissionsView.vue * style: lint fix * chore: restore config.mts file: * chore: contents of config.mts * fix: no submissions before start (#440) * fix: no submissions before start * chore: move project startdate * chore: demo * chore: demo * chore: allow joining group after start * chore: git merge * fix: empty docker image * chore: typo * chore: modify gitignore * fix: deadline (#461) * chore: better colors for submission status * chore: more descriptive text * fix: select other months' date (#462) * feat: notifications frontend (#460) * chore: notifications (wip) * chore: notifications (wip) * feat: notifications in frontend * chore: added files * chore: notification creation * fix: fixed some weird shizzles * chore: notifications * chore: disabled load more button when no notifications * chore: linting * chore: removed vitepress cache * fix: score creation * chore: linting --------- Co-authored-by: Topvennie <[email protected]> * chore: fix help * fix (#467) * fix: assets (#466) * fix: small submission fixes (#465) * fix translations, fix links, fix errors * fix: delete garbage * fix: small changes * chore: fixing submission * fix: submission permissions * chore: linting * feat: notifications frontend (#460) * chore: notifications (wip) * chore: notifications (wip) * feat: notifications in frontend * chore: added files * chore: notification creation * fix: fixed some weird shizzles * chore: notifications * chore: disabled load more button when no notifications * chore: linting * chore: removed vitepress cache * fix: score creation * chore: linting --------- Co-authored-by: Topvennie <[email protected]> * fix: translations --------- Co-authored-by: lander <[email protected]> Co-authored-by: Topvennie <[email protected]> Co-authored-by: Bram Meir <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Vincent Vallaeys <[email protected]> Co-authored-by: Brent Silkyn <[email protected]> Co-authored-by: francis <[email protected]> Co-authored-by: Bram Meir <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Francis Vauterin <[email protected]> Co-authored-by: Bram Meir <[email protected]> Co-authored-by: Tybo Verslype <[email protected]> Co-authored-by: Lander Maes <[email protected]> Co-authored-by: tyboro2002 <[email protected]> Co-authored-by: lander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now views get to decide whether they want to add a create message or not.
Have also added some handy general translations for success messages.