-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run checks #397
Run checks #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the change to the structureCheckModel, the fixtures do not work anymore (and seeder probably too). It would be nice if these worked first so the frontend developers do not experience errors.
Could it be possible to make a working example? |
# Conflicts: # backend/api/locale/en/LC_MESSAGES/django.po # backend/api/locale/nl/LC_MESSAGES/django.po # backend/api/logic/check_folder_structure.py # backend/api/logic/get_file_path.py # backend/api/models/submission.py # backend/api/serializers/checks_serializer.py # backend/api/serializers/project_serializer.py # backend/api/signals.py # backend/api/tasks/extra_check.py # backend/api/tests/helpers.py # backend/api/tests/test_file_structure.py # backend/api/views/checks_view.py # backend/api/views/project_view.py # backend/api/views/submission_view.py
Changes requested here! |
👍 |
DELETE YOUR
.env
FILEDELETE YOUR DATABASE
RUN
./development -c
Route Changes
Submissions
A submission is zipped upon receiving.
No matter the content received.
This can lead to a zip inside a zip but no problem!
Zip Parsing
-
to make it a blocked extension.test.-py
will result in the blocked extensionpy
.Checks
Extra checks are run after structure checks and only if the structure checks succeed.
Teachers / assistans have the ability to trigger the desired error message by exiting their bash script with the right exit code.
Type Checking
For the chad VSCode Pylance users, the amount of typing errors decreased drastically 🎉
Models
Checks
checks.py
Submission
SubmissionFile
model.Check Result
ExtraCheckResult
to indicate that it didn't run because the structure checks didn't succeed.StructureCheck
Docker Image
state
. Can be one of the following:Extra Check