chore: fixed some layout issues #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BramMeir
requested changes
Apr 25, 2024
frontend/src/assets/lang/nl.json
Outdated
Comment on lines
26
to
29
| "noProjects": { | ||
| "student": "Geen lopende projecten gevonden voor alle ingeschreven vakken. Schrijf in op een openbaar vak met de zoekfunctie, of gebruik een uitnodiginslink van een lesgever.", | ||
| "teacher": "Geen lopende projecten gevonden voor de vakken waarvoor je lesgever bent." | ||
| }, |
There was a problem hiding this comment.
Maybe we also add something like this specifically for the detail page of a course, because now these are also displayed there.
frontend/src/assets/lang/nl.json
Outdated
| "noIncomingProjects": "Geen projecten met een deadline binnen de 7 dagen.", | ||
| "noCourses": "Geen vakken beschikbaar voor dit academiejaar.", | ||
| "noCourses": "Geen vakken gevonden. Schrijf in op een openbaar vak met de zoekfunctie, of gebruik een uitnodiginslink van een lesgever.", |
There was a problem hiding this comment.
Perhaps we should also make the distinction here between teacher/student, because now this is also shown for a teacher that has no courses.
BramMeir
approved these changes
Apr 26, 2024
DeLany123
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore: fixed some layout issues * chore: project card fixes * chore: seperated course cards * chore: linting * chore: changes to make bram happy * chore: fixed translatiosn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #349
closes #348