Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission logic #107

Merged
merged 17 commits into from
Mar 14, 2024
Merged

Submission logic #107

merged 17 commits into from
Mar 14, 2024

Conversation

tyboro2002
Copy link
Contributor

No description provided.

@tyboro2002 tyboro2002 requested a review from Topvennie March 14, 2024 13:24
@tyboro2002 tyboro2002 self-assigned this Mar 14, 2024
@tyboro2002 tyboro2002 added this to the Backend milestone milestone Mar 14, 2024
Topvennie
Topvennie requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the .gitignore file to accommodate for the new location of the test zip files.

backend/api/tests/test_submission.py Outdated Show resolved Hide resolved
backend/api/tests/test_submission.py Outdated Show resolved Hide resolved
@tyboro2002 tyboro2002 requested a review from Topvennie March 14, 2024 14:01
@tyboro2002
Copy link
Contributor Author

tyboro2002 commented Mar 14, 2024 •
edited
Loading

closes #73, #74, #75, #76

Topvennie
Topvennie requested changes Mar 14, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
backend/api/tests/test_submission.py Outdated Show resolved Hide resolved
@tyboro2002 tyboro2002 requested a review from Topvennie March 14, 2024 14:08
Topvennie
Topvennie approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj :)

BramMeir
BramMeir approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@BramMeir BramMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tyboro2002 tyboro2002 merged commit ffbab50 into development Mar 14, 2024
2 checks passed
@BramMeir BramMeir deleted the submission_logic branch March 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BramMeir BramMeir BramMeir approved these changes

@Topvennie Topvennie Topvennie approved these changes

@francisvaut francisvaut Awaiting requested review from francisvaut

Assignees

@tyboro2002 tyboro2002

Labels
None yet
Projects
None yet
Milestone
Backend milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyboro2002 @Topvennie @BramMeir