Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: fix teacher delete bug in admin panel #355

Closed
bsilkyn opened this issue Apr 19, 2024 · 0 comments · Fixed by #364
Closed

frontend: fix teacher delete bug in admin panel #355

bsilkyn opened this issue Apr 19, 2024 · 0 comments · Fixed by #364
Assignees
@bsilkyn
Labels
bug Something isn't working frontend Issues regarding the frontend prio: medium
Milestone
Final milestone

Comments

@bsilkyn
Copy link
Contributor

bsilkyn commented Apr 19, 2024

There is a bug in admin panel, where if you delete the teacher role, the student role gets deleted instead.
@bsilkyn bsilkyn added this to the Final milestone milestone Apr 19, 2024
@bsilkyn bsilkyn self-assigned this Apr 19, 2024
bsilkyn added a commit that referenced this issue Apr 19, 2024
@bsilkyn
fix: fixed bug where deleting teacher role would delete the student r…
437012b 
…ole #355
bsilkyn added a commit that referenced this issue Apr 19, 2024
@bsilkyn
refactor: re-center search icons + use multiselect for role filtering…
46ce8a8 
… + update global select #355
@bsilkyn bsilkyn added bug Something isn't working frontend Issues regarding the frontend labels Apr 20, 2024
bsilkyn added a commit that referenced this issue Apr 20, 2024
@bsilkyn
fix: fixed bug where deleting teacher role would delete the student r…
98f1ea0 
…ole #355
bsilkyn added a commit that referenced this issue Apr 20, 2024
@bsilkyn
refactor: re-center search icons + use multiselect for role filtering…
c3de1b6 
… + update global select #355
bsilkyn added a commit that referenced this issue Apr 21, 2024
@bsilkyn
fix: fixed bug where deleting teacher role would delete the student r…
2fe466f 
…ole #355
bsilkyn added a commit that referenced this issue Apr 21, 2024
@bsilkyn
refactor: re-center search icons + use multiselect for role filtering…
391d2a4 
… + update global select #355
@bsilkyn bsilkyn mentioned this issue Apr 21, 2024
Merged
BramMeir pushed a commit that referenced this issue Apr 24, 2024
@bsilkyn
fix: Admin panel fix (#364)
be953ba 
* fix: fixed bug where deleting teacher role would delete the student role #355

* refactor: re-center search icons + use multiselect for role filtering + update global select #355

* chore: get data table out of Title component and put into Body component

* fix: proper translation of roles in admin table

* refactor: lint fixes

* fix: accidentally deleted I18n as import, now fixed
DeLany123 pushed a commit that referenced this issue Apr 29, 2024
@bsilkyn @DeLany123
fix: Admin panel fix (#364)
e879d59 
* fix: fixed bug where deleting teacher role would delete the student role #355

* refactor: re-center search icons + use multiselect for role filtering + update global select #355

* chore: get data table out of Title component and put into Body component

* fix: proper translation of roles in admin table

* refactor: lint fixes

* fix: accidentally deleted I18n as import, now fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsilkyn bsilkyn

Labels
bug Something isn't working frontend Issues regarding the frontend prio: medium
Projects
None yet
Milestone
Final milestone
Development

Successfully merging a pull request may close this issue.

fix: Admin panel fix SELab-2/UGent-7
1 participant
@bsilkyn