Project endpoint #47

lars-vc · 2022-03-05T13:38:26Z

Project endpoint, closes #44
Endpoints:

GET /projects
PUT /projects
GET /projects/projID
DELETE /projects/projID
GET /projects/projID/students
GET /projects/projID/coaches
PUT /projects/projID/students
PUT /projects/projID/coaches
DELETE /projects/projID/students/studID
DELETE /projects/projID/coaches/coachID

TomAlard · 2022-03-05T14:06:13Z

Why is this branch based on the student endpoint branch?

lars-vc · 2022-03-05T19:53:07Z

I wanted to follow the example of student endpoint

NielsPraet · 2022-03-07T10:37:39Z

It's always nice to have a bit more information in the PR description about what exactly you are implementing in this branch because with a larger amount of changed files, it can get quite unclear :)

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectControllerTests.kt

backend/src/main/kotlin/be/osoc/team1/backend/entities/Project.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectServiceTests.kt

backend/src/main/kotlin/be/osoc/team1/backend/exceptions/FailedOperationException.kt

…into project-endpoint

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/StudentServiceTests.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectControllerTests.kt

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt

backend/src/main/kotlin/be/osoc/team1/backend/services/ProjectService.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectServiceTests.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/StudentServiceTests.kt

TomAlard · 2022-03-10T15:42:49Z

There's still a couple untested functions, is this intentional?

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectControllerTests.kt

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectServiceTests.kt

lars-vc added 2 commits March 5, 2022 14:33

chore: made projectrepo and projectservice

68a79b1

chore: added ProejctServiceTests

3fe4295

lars-vc added 8 commits March 6, 2022 11:04

chore: working on projectcontroller

2a9ad40

Merge branch 'development' into project-endpoint

d71aab1

Merge branch 'development' into project-endpoint

d742df3

chore: bug in get project

ecd0fe2

Merge branch 'student_endpoint' into project-endpoint

887b87e

fix: bug is resolved

c376cea

feat: projectcontroller almost done

f26f0fd

Merge branch 'student_endpoint' into project-endpoint

5f41adc

lars-vc added 3 commits March 8, 2022 10:51

chore: tests of service is done

ecafcb0

chore: tests for projectcontroller

17223ea

chore: formatting

f8ebeb4

lars-vc marked this pull request as ready for review March 8, 2022 11:51

lars-vc requested review from MaartenS11, NielsPraet, TomAlard and Mikxox March 8, 2022 11:51

lars-vc added 2 commits March 8, 2022 13:37

Merge branch 'development' into project-endpoint

d90789f

fix: newline at end of file

72dcc86

TomAlard reviewed Mar 8, 2022

View reviewed changes

lars-vc added 4 commits March 8, 2022 14:42

fix: fixes as requested by tom

1f999b9

Merge branch 'project-endpoint' of https://github.com/SELab-2/OSOC-1 …

3f1355d

…into project-endpoint

fix: second round of tom comment fixes

bf6ec5e

fix: changes

9945529

Mikxox reviewed Mar 9, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt Outdated Show resolved Hide resolved

Mikxox reviewed Mar 9, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt Outdated Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/test/kotlin/be/osoc/team1/backend/unittests/StudentServiceTests.kt Outdated Show resolved Hide resolved

fix: test change

da3dee3

TomAlard reviewed Mar 10, 2022

View reviewed changes

lars-vc added 2 commits March 10, 2022 15:22

chore: more fixes

85373cf

chore: ktlint

636e15b

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt Outdated Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/controllers/ProjectController.kt Show resolved Hide resolved

lars-vc added 2 commits March 10, 2022 15:45

fix: put to post

7d177c0

fix: fix

006fc5c

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/services/ProjectService.kt Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/services/ProjectService.kt Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/services/ProjectService.kt Outdated Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/main/kotlin/be/osoc/team1/backend/services/ProjectService.kt Outdated Show resolved Hide resolved

fix: updated docs

582f4b1

lars-vc requested review from TomAlard, Mikxox and NielsPraet March 10, 2022 15:33

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectServiceTests.kt Outdated Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectServiceTests.kt Outdated Show resolved Hide resolved

TomAlard reviewed Mar 10, 2022

View reviewed changes

backend/src/test/kotlin/be/osoc/team1/backend/unittests/StudentServiceTests.kt Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectControllerTests.kt Outdated Show resolved Hide resolved

Mikxox reviewed Mar 10, 2022

View reviewed changes

backend/src/test/kotlin/be/osoc/team1/backend/unittests/ProjectServiceTests.kt Outdated Show resolved Hide resolved

chore: extra tests

58030dd

Mikxox approved these changes Mar 10, 2022

View reviewed changes

TomAlard self-requested a review March 10, 2022 18:47

TomAlard approved these changes Mar 10, 2022

View reviewed changes

lars-vc merged commit 3fdbb7b into development Mar 10, 2022

lars-vc deleted the project-endpoint branch March 10, 2022 18:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Project endpoint #47

Project endpoint #47

lars-vc commented Mar 5, 2022 •

edited

Loading

TomAlard commented Mar 5, 2022

lars-vc commented Mar 5, 2022

NielsPraet commented Mar 7, 2022

TomAlard commented Mar 10, 2022

Project endpoint #47

Project endpoint #47

Conversation

lars-vc commented Mar 5, 2022 • edited Loading

TomAlard commented Mar 5, 2022

lars-vc commented Mar 5, 2022

NielsPraet commented Mar 7, 2022

TomAlard commented Mar 10, 2022

lars-vc commented Mar 5, 2022 •

edited

Loading