Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Frontend Migration #41

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Frontend Migration #41

merged 2 commits into from
Mar 6, 2022

Conversation

NielsPraet
Copy link
Contributor

Closes #40

@NielsPraet NielsPraet added this to the Milestone 1 milestone Mar 4, 2022
@NielsPraet NielsPraet self-assigned this Mar 4, 2022
@TomAlard
Copy link
Contributor

TomAlard commented Mar 5, 2022

Why are we switching to yarn?

@NielsPraet
Copy link
Contributor Author

Why are we switching to yarn?

Yarn is all around a lot nicer to use, it has:

  • way faster installation of project dependencies (Yarn does this in parallel)
  • command outputs are a lot cleaner
  • npm has a history of some pretty serious security vulnerabilities

Nyxes5
Nyxes5 approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@Nyxes5 Nyxes5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue to fix deployment for yarn, I'll look into it then

@NielsPraet NielsPraet merged commit ad28c3a into development Mar 6, 2022
@TomAlard TomAlard deleted the frontend-migration branch March 9, 2022 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lars-vc lars-vc lars-vc approved these changes

@Nyxes5 Nyxes5 Nyxes5 approved these changes

@TomAlard TomAlard TomAlard approved these changes

@MaartenS11 MaartenS11 Awaiting requested review from MaartenS11

@Mikxox Mikxox Awaiting requested review from Mikxox

@tvhimme tvhimme Awaiting requested review from tvhimme

Assignees

@NielsPraet NielsPraet

Labels
None yet
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.

Refactor front-end code
4 participants
@NielsPraet @TomAlard @Nyxes5 @lars-vc