Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Initial API description #25

Merged
merged 9 commits into from
Mar 7, 2022
Merged

Initial API description #25

merged 9 commits into from
Mar 7, 2022

Conversation

MaartenS11
Copy link
Contributor

This merge request adds an API description written to follow the OpenAPI specification. It is currently incomplete.

Upon completion it will close #23

@MaartenS11 MaartenS11 added documentation Improvements or additions to documentation high priority labels Feb 27, 2022
@MaartenS11 MaartenS11 added this to the Milestone 1 milestone Feb 27, 2022
@MaartenS11 MaartenS11 self-assigned this Feb 27, 2022
@NielsPraet
Copy link
Contributor

Make sure to ask for help if you need it 😉

@NielsPraet NielsPraet self-assigned this Mar 1, 2022
@TomAlard TomAlard mentioned this pull request Mar 3, 2022
@TomAlard
Copy link
Contributor

TomAlard commented Mar 4, 2022

Is it appropriate that this is still a draft PR?

@MaartenS11 MaartenS11 mentioned this pull request Mar 5, 2022
This was referenced Mar 5, 2022
@NielsPraet
Copy link
Contributor

I think we can merge this branch for now, we can always edit things later

@MaartenS11 MaartenS11 changed the title Api description Initial API description Mar 5, 2022
@MaartenS11 MaartenS11 marked this pull request as ready for review March 5, 2022 14:09
TomAlard
TomAlard previously approved these changes Mar 5, 2022
also added get /projects/id/students for a list of students
@lars-vc lars-vc requested review from TomAlard and lars-vc March 6, 2022 09:47
lars-vc
lars-vc previously approved these changes Mar 6, 2022
@TomAlard
Copy link
Contributor

TomAlard commented Mar 6, 2022

I've changed the documentation so that id's don't have to be sent in requests to the server

image

The server still has to answer with an id, of course

image

@TomAlard
Copy link
Contributor

TomAlard commented Mar 6, 2022

There's still an issue with the documentation at the moment

image

The "Try it out" button on the right side doesn't work. It would be nice to fix this, but I guess this could be done in a separate issue.

@bmesuere bmesuere mentioned this pull request Mar 6, 2022
@NielsPraet
Copy link
Contributor

@MaartenS11 You can merge this :)

@TomAlard TomAlard merged commit 2ab3f7e into development Mar 7, 2022
@TomAlard TomAlard deleted the api_desc branch March 7, 2022 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define endpoints using the OpenAPI spec
5 participants