Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Remove organizations from users #222

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Remove organizations from users #222

merged 5 commits into from
Apr 15, 2022

Conversation

TomAlard
Copy link
Contributor

Closes #221. This only removes organizations from the users code, as it's the only part that was already on the development branch. I'll fix the other endpoints in their respective PR's.

Checklist

Breaking change checklist:

  • I've updated the existing tests to account for the changes in expected behavior
  • I've updated the documentation to reflect the new behavior
  • I've updated the osoc.yaml file

@lars-vc
Copy link
Contributor

lars-vc commented Apr 14, 2022

Do we need this pr? Since the project edition project has also implemented this, it might be less confusing to keep it on 1 pr to avoid confusion when changes get requested

This was referenced Apr 14, 2022
@Mikxox
Copy link
Contributor

Mikxox commented Apr 14, 2022

Can you also remove organisations from the open to post url /*/users in configutil to /users ? I think that should be all.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #222 (384be99) into development (7189af3) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             development     #222      +/-   ##
=================================================
- Coverage          95.92%   95.69%   -0.23%     
+ Complexity           215      213       -2     
=================================================
  Files                 43       43              
  Lines                491      488       -3     
  Branches              37       37              
=================================================
- Hits                 471      467       -4     
- Misses                10       11       +1     
  Partials              10       10              
Flag Coverage Δ
all_tests 95.69% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...main/kotlin/be/osoc/team1/backend/entities/User.kt 94.11% <ø> (-5.89%) ⬇️
...e/osoc/team1/backend/controllers/UserController.kt 100.00% <100.00%> (ø)
...otlin/be/osoc/team1/backend/security/ConfigUtil.kt 100.00% <100.00%> (ø)
...tlin/be/osoc/team1/backend/services/UserService.kt 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TomAlard
Copy link
Contributor Author

Do we need this pr? Since the project edition project has also implemented this, it might be less confusing to keep it on 1 pr to avoid confusion when changes get requested

I think merging this should actually reduce the confusion, as the changes made here will not be shown in the other PR's once we merge this.

@TomAlard TomAlard merged commit 60fc34f into development Apr 15, 2022
@TomAlard TomAlard deleted the remove-organizations branch April 15, 2022 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove organizations
5 participants