This repository has been archived by the owner on May 24, 2022. It is now read-only.
Add TTL and User to login response #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsPraet
approved these changes
Apr 5, 2022
MaartenS11
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Found it a bit weird that there were 2 classes with inheritance at first but after reading the code I found that it did make some sense to do it that way to reduce coupling between Users and the more generic TokenUtil class. It's actually a reasonably nice besides the maybe slightly higher coupling created by directly referencing EntityViews.Public in addDataToHttpResponse but I doubt we will be changing that much so it's probably fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal is to add refresh token TTL to all responses with new tokens and to add user object to login response. Part of this functionality was already done by @MaartenS11, but my previous PR merge broke this.