This repository has been archived by the owner on May 24, 2022. It is now read-only.
Fix bug testcontainers not being used correctly #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsPraet
approved these changes
Apr 1, 2022
Nyxes5
approved these changes
Apr 1, 2022
This was referenced Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring overwrites the testcontainer connection by using the
getDataSourcebean fromDataSourceConfig.kt. This means integration tests were connecting to your actual local database and not the testcontainer database. This could obviously lead to wrong results! Has now been fixed and integration tests now don't need a companion object anymore.