Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from TraVarT-kconfig #4

Merged
merged 13 commits into from
Nov 28, 2024
Merged

Fixes from TraVarT-kconfig #4

merged 13 commits into from
Nov 28, 2024

Conversation

6b6279
Copy link
Contributor

@6b6279 6b6279 commented Nov 13, 2024

Most of these fixes came to be during the development of TraVarT-kconfig, which currently depends on my own fork.

In summary:

  • Contain small Maven repository for FeatureIDE external library (see pom.xml and lib subdirectory)
  • Add multiple addition methods for Constraints
  • Fix retrieval of features in getFeature (fetch mapping from root feature to ensure that all features from the FM are reachable)
  • Refactor IConfigurable (use “Configured” instead of “Selected”)
  • Fix getGroup; now behaves according to Javadoc contract with regard to group indexes

It's a bit rough around the edges, but I'd be ready to refactor, e.g. the NPE bypass in setGroup.

@coemgen1992 coemgen1992 merged commit b5dd9fe into SECPS:main Nov 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants