Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random functions tests and truncexpon #441

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add random functions tests and truncexpon #441

merged 1 commit into from
Apr 24, 2024

Conversation

enekomartinmartinez
Copy link
Collaborator

@enekomartinmartinez enekomartinmartinez commented Apr 23, 2024 •
edited
Loading

Description

  • Add random functions tests
  • Fix truncation in Vensim's RANDOM NORMAL
  • Support Vensim's RANDOM EXPONENTIAL

Related issues

#107
#370

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Testing

PR verification (to be filled by reviewers)

  • The code follows the PEP 8 style
  • The new code has been tested properly for all the possible cases
  • The overall coverage has not dropped and other features have not been broken.
  • If new features have been added, they have been properly documented
  • docs/whats_new.rst has been updated
  • PySD version has been updated

@enekomartinmartinez enekomartinmartinez marked this pull request as draft April 23, 2024 15:40
@enekomartinmartinez enekomartinmartinez mentioned this pull request Apr 23, 2024
Merged
@enekomartinmartinez
Copy link
Collaborator Author

Note that tests failed because I am still missing to merge SDXorg/test-models#92 and update the commit.

@enekomartinmartinez enekomartinmartinez marked this pull request as ready for review April 24, 2024 16:19
@enekomartinmartinez enekomartinmartinez merged commit 458598b into master Apr 24, 2024
15 checks passed
@enekomartinmartinez enekomartinmartinez deleted the random_functions branch April 24, 2024 16:25
enekomartinmartinez added a commit that referenced this pull request Apr 24, 2024
@enekomartinmartinez
Add random functions tests and truncexpon (#441)
ad41aa8 
- Add random functions tests
- Fix truncation in Vensim's RANDOM NORMAL
- Support Vensim's RANDOM EXPONENTIAL
enekomartinmartinez added a commit that referenced this pull request Jun 27, 2024
@enekomartinmartinez
Add random functions tests and truncexpon (#441)
7a3510a 
- Add random functions tests
- Fix truncation in Vensim's RANDOM NORMAL
- Support Vensim's RANDOM EXPONENTIAL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug python builder vensim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enekomartinmartinez