Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data and subscript functions #209

Closed
wants to merge 30 commits into from

Conversation

julienmalard
Copy link
Contributor

Added basic subscript functions (! operator) and external (Excel) data loading functions.

@alexprey
Copy link
Collaborator

Hi @julienmalard!
Nice to see new work for pysd library and thanks to you for work!
Can you please merge latest version of master branch to your base branch to make it easy check and approve this pull request.

@julienmalard
Copy link
Contributor Author

Hello,
Is it better now? Sorry for my inexperience with git (despite years of use...)

@coveralls
Copy link

coveralls commented Sep 25, 2019

Coverage Status

Coverage decreased (-10.4%) to 80.34% when pulling 0cd40b3 on julienmalard:new_functions into bf1b1d0 on JamesPHoughton:master.

@alexprey
Copy link
Collaborator

alexprey commented Nov 5, 2019

Thanks for contribution!
It can be merged if code coverage are keep on the same level, 10% reducing is really bad situation. I can try to add some tests when have a time, but it really better if you can test your code with new test!

@alexprey
Copy link
Collaborator

alexprey commented Nov 5, 2019

Hi, @julienmalard
I'm just looking at travis build logs and see that more tests are failed because can't import some modules. You also can check it here: https://travis-ci.org/JamesPHoughton/pysd/jobs/596664050

@alexprey
Copy link
Collaborator

alexprey commented Nov 5, 2019

@julienmalard and some tests failing for python 3: https://travis-ci.org/JamesPHoughton/pysd/jobs/596664051

@DVRodri8
Copy link
Contributor

DVRodri8 commented Apr 1, 2020

@julienmalard are you still working on this? my intention is try to fix this branch, we can work together.

@julienmalard
Copy link
Contributor Author

@DVRodri8 thank you! I would be quite interested in working together to fix this branch. In particular, I am not quite sure how to add the tests (since they would have to be added to the git submodule).

@julienmalard
Copy link
Contributor Author

@alexprey appologies for the delay. I am not quite sure what is causing the test errors (in the from . import py_backend from integration_test_vensim_pathway); it runs fine on my local machine. Could this be a Python 2 issue? Thanks!

@enekomartinmartinez
Copy link
Collaborator

The content of this PR is already in #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants