Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PySD to SDXorg #348

Closed
24 of 26 tasks
enekomartinmartinez opened this issue Aug 3, 2022 · 16 comments
Closed
24 of 26 tasks

Move PySD to SDXorg #348

enekomartinmartinez opened this issue Aug 3, 2022 · 16 comments

Comments

@enekomartinmartinez
Copy link
Collaborator

enekomartinmartinez commented Aug 3, 2022

We want to move the PySD official repo to SDXorg organization. Nevertheless, GitHub takes care of migrating everything a redirecting the links we may need to take care of several things.

Expected migration date: mid-September

TODOs before migration

  • Inform all current and past developers about the incoming change. Includying those who have projects that depend on PySD (use dependencies tree from the repo).
  • Check with JOSS pending review if this may cause any conflicts on the process.
  • Migrate PySD CookBook and checkif there are conflicts with RTD

TODOs after migration

  • Update all the links in PySD to the new repo.
  • Update external links that point to PySD (that we know about)
  • Update all the links in libraries that depen on PySD to the new repo.
    • excels2vensim
    • sdqc
    • pysd2r
    • SDVerificationToolKit
  • Check if secrets where properly migrated, this includes pip tokens for automatic publications of new releases.
  • Check if new releases are properly uploaded to pip.
  • Update the conda-forge recipe with the repo link.
  • Update permissions/access controls
  • Check if RTD works properly after migration and/or make neccesary updates.
  • Check if pep8 linter works properly in PR or include it again.
  • Check if coveralls works properly on pushes and PR.
  • Create an about the project section explaining the origin of the project mentioning all the main contributions, evolution and linking to the contributors page.
  • Create a table with "Who to contact" with the main developers information per "section" of PySD.
  • Update the license to extent it to 2022 and make a more general autorship.
  • Inform all current and past developers about the incoming change. Includying those who have projects that depend on PySD (use dependencies tree from the repo).
@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton are we moving as well the PySD cookbook?

@JamesPHoughton
Copy link
Collaborator

@JamesPHoughton are we moving as well the PySD cookbook?

I think that would make sense. It could use some attention anyways, maybe it would be a good way to get that going. =)

@enekomartinmartinez
Copy link
Collaborator Author

I agree, we need to update the cookbook with the latest version. I think it could also be a good test to move the cookbook first so we can see how RDT reacts to moving the repo. Maybe we can move it before the end of this week so I can make some tests during next week?

@JamesPHoughton
Copy link
Collaborator

I think this is going to need to be after I get back from travel. I'll have some time the morning of the 7th or 8th of Sept. Should we work through it together?

@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton great.
For now both days work for me. But I will confirm it in the first week of September.

@enekomartinmartinez
Copy link
Collaborator Author

About the paper review, I have found the following information:
https://joss.readthedocs.io/en/latest/editorial_bot.html?highlight=repository#changing-the-repository

@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton @alexprey @rogersamso @julienmalard @SimonStrong @ConnectedSystems @pbreach @DVRodri8 @ainar @keith-citrenbaum @JoonaTuovinen @rugue1 @mhy05 @marrobl @sepiatone
Hi all,
I just wanted to let you know that we will move PySD to SDXorg organization in September. As there have been several contributions to PySD I would like to add an about section in the documentation where we reflect who made each contribution to the code. So if you want to appear in this section please write a short of message about your contributions to PySD and when they were done.
Mention any other developers if you miss them here.

Once the migration has been done GitHub will automatically redirect https://github.com/JamesPHoughton/pysd to https://github.com/SDXorg/pysd, however, it would be better if you update your links to PySD.

@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton I was trying to migrate excels2vensim from GitLab to SDXorg. I am having the following error with RTD, I think it means that we need to give permisions to RTD to acces SDXorg projects.

[rtd-command-info] start-time: 2022-08-31T11:11:20.075404Z, end-time: 2022-08-31T11:11:20.224909Z, duration: 0, exit-code: 128
git clone --no-single-branch --depth 50 https://github.com/SDXorg/excels2vensim .
Cloning into '.'...
fatal: could not read Username for 'https://github.com': terminal prompts disabled

We need also to give access to coveralls

@enekomartinmartinez
Copy link
Collaborator Author

It would be interesting to configure this GHAction for checking the links
https://github.com/lycheeverse/lychee-action

@enekomartinmartinez
Copy link
Collaborator Author

https://github.com/codespell-project/actions-codespell

@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton @alexprey @rogersamso @julienmalard @SimonStrong @ConnectedSystems @pbreach @DVRodri8 @ainar @keith-citrenbaum @JoonaTuovinen @rugue1 @mhy05 @marrobl @sepiatone
We have already migrated PySD!!!
It is recommendable that you update your URLs to point to SDXorg instead of JamesPHoughton

@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton RTD is not working in PR we need to check/update the link in RTD configuration and check the integration section

@julienmalard
Copy link
Contributor

@enekomartinmartinez Wonderful! Regarding my contributions, I think they were mostly limited to adding Unicode support some time back. #179

@enekomartinmartinez
Copy link
Collaborator Author

@JamesPHoughton we still need to correct the RTD webhook. I do not have access to the RTD project!

@JamesPHoughton
Copy link
Collaborator

JamesPHoughton commented Oct 2, 2022 via email

@enekomartinmartinez
Copy link
Collaborator Author

Seems that in the repo is set correctly as GitHub it says so. But probably we are missing something in the RTD project as RTD is not building the docs in PRs.

Note that the RTD for the cookbook was not updated after the last changes.

@enekomartinmartinez enekomartinmartinez closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants